Skip to content

Add asset-name support to GHReleaseDownloader#107

Merged
Mzack9999 merged 3 commits intomainfrom
fix-gh-releasse-asset-name
Mar 16, 2023
Merged

Add asset-name support to GHReleaseDownloader#107
Mzack9999 merged 3 commits intomainfrom
fix-gh-releasse-asset-name

Conversation

@RamanaReddy0M
Copy link
Copy Markdown
Contributor

@RamanaReddy0M RamanaReddy0M commented Mar 16, 2023

Description:

  • Add the AssetName field to GHReleaseDownloader struct

  • use AssetName to get AssetId instead ToolName

  • Reference:

    AssetName string

@RamanaReddy0M RamanaReddy0M self-assigned this Mar 16, 2023
@RamanaReddy0M RamanaReddy0M linked an issue Mar 16, 2023 that may be closed by this pull request
2 tasks
Copy link
Copy Markdown
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

./tlsx -up
  

  _____ _    _____  __
 |_   _| |  / __\ \/ /
   | | | |__\__ \>  < 
   |_| |____|___/_/\_\	v1.0.5

		projectdiscovery.io

7.60 MiB / 7.60 MiB [--------------------------------------------------------] 100.00% 25.71 MiB p/s

[INF] tlsx sucessfully updated 1.0.5 -> 1.0.6 (latest)

  ## What's Changed                                                           
                                                                              
  • Added version check with self update option by @RamanaReddy0M in          
  https://github.com/projectdiscovery/tlsx/pull/197                           
                                                                              
       -up, -update                 update tlsx to latest version             
                                                                              
  • Added untrusted certificate misconfig detection by @ShubhamRasal in       
  https://github.com/projectdiscovery/tlsx/pull/211                           
                                                                              
       -un, -untrusted  display host with untrusted certificate               
                                                                              
  • Added certificate serial in output by @RamanaReddy0M in                   
  https://github.com/projectdiscovery/tlsx/pull/212                           
                                                                              
       -se, -serial  display certificate serial number                        
                                                                              
  • Added cipher enumeration based on security level by @tarunKoyalwar in     
  https://github.com/projectdiscovery/tlsx/pull/177                           
                                                                              
       -ct, -cipher-type value  ciphers types to enumerate                    
  (all/secure/insecure/weak) (default all)                                    
                                                                              
  • Added reverse PTR SNI support by @Mzack9999 in                            
  https://github.com/projectdiscovery/tlsx/pull/175                           
  • Fixed data race crash in cert revoke check by @tarunKoyalwar in           
  https://github.com/projectdiscovery/tlsx/pull/213                           
  • Fixed openssl tls version selection by @Mzack9999 in                      
  https://github.com/projectdiscovery/tlsx/pull/204                           
  • Fixed asnmap + mapcidr deps by @Mzack9999 in                              
  https://github.com/projectdiscovery/tlsx/pull/182                           
                                                                              
  ## New Contributors                                                         
                                                                              
  • @RamanaReddy0M made their first contribution in                           
  https://github.com/projectdiscovery/tlsx/pull/197                           
                                                                              
  Full Changelog:                                                             
  https://github.com/projectdiscovery/tlsx/compare/v1.0.5...v1.0.6            



@tarunKoyalwar tarunKoyalwar requested review from Mzack9999 and removed request for ehsandeep March 16, 2023 12:33
@Mzack9999 Mzack9999 merged commit 839aeb4 into main Mar 16, 2023
@Mzack9999 Mzack9999 deleted the fix-gh-releasse-asset-name branch March 16, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add asset-name support to GHReleaseDownloader

3 participants