Skip to content

fix: do not render default schema when dropping items in it#5675

Merged
jacek-prisma merged 1 commit intomainfrom
fix/fix-drop-item-schema-rendering
Oct 29, 2025
Merged

fix: do not render default schema when dropping items in it#5675
jacek-prisma merged 1 commit intomainfrom
fix/fix-drop-item-schema-rendering

Conversation

@jacek-prisma
Copy link
Copy Markdown
Contributor

TML-1527

We need some special handling when dropping items in the default schema. More explanation in comments.

Fixes prisma/prisma#28312

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #5675 will not alter performance

Comparing fix/fix-drop-item-schema-rendering (4a90859) with main (420f95b)

Summary

✅ 11 untouched

@github-actions
Copy link
Copy Markdown
Contributor

WASM Query Engine File Size

Engine This PR Base branch Diff
Postgres 2.192MiB 2.192MiB 0.000B
Postgres (gzip) 868.802KiB 868.799KiB 3.000B
Mysql 2.159MiB 2.159MiB 0.000B
Mysql (gzip) 855.466KiB 855.465KiB 1.000B
Sqlite 2.071MiB 2.071MiB 0.000B
Sqlite (gzip) 820.569KiB 820.566KiB 3.000B
SQL Server 2.130MiB 2.130MiB 0.000B
SQL Server (gzip) 846.106KiB 846.195KiB -91.000B
CockroachDB 2.214MiB 2.214MiB 0.000B
CockroachDB (gzip) 877.034KiB 877.031KiB 3.000B

WASM Query Compiler File Size

Engine This PR Base branch Diff
Postgres 1.860MiB 1.860MiB 0.000B
Postgres (gzip) 734.134KiB 734.135KiB -1.000B
Mysql 1.827MiB 1.827MiB 0.000B
Mysql (gzip) 722.633KiB 722.637KiB -4.000B
Sqlite 1.786MiB 1.786MiB 0.000B
Sqlite (gzip) 705.316KiB 705.317KiB -1.000B
SQL Server 1.858MiB 1.858MiB 0.000B
SQL Server (gzip) 735.798KiB 735.797KiB 1.000B
CockroachDB 1.885MiB 1.885MiB 0.000B
CockroachDB (gzip) 744.347KiB 744.353KiB -6.000B

@aqrln aqrln added this to the 6.19.0 milestone Oct 29, 2025
@jacek-prisma jacek-prisma merged commit 2ba551f into main Oct 29, 2025
235 checks passed
@jacek-prisma jacek-prisma deleted the fix/fix-drop-item-schema-rendering branch October 29, 2025 19:02
Aijeyomah pushed a commit to Aijeyomah/prisma-engines that referenced this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prisma migration in postgres will add schema settings when dropping table

2 participants