fix(instrumentation): make @opentelemetry/api as external#28820
Merged
Conversation
This package is specified as a peer dependency and should not be bundled (otherwise users end up with two copies of this package in their application).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the @opentelemetry/api package from being bundled in the instrumentation package by adding it to the external dependencies list in the build configuration. Since @opentelemetry/api is declared as a peer dependency, bundling it would result in users having duplicate copies of the package in their applications.
- Added
@opentelemetry/apito the external dependencies array in the esbuild configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
size-limit report 📦
|
Contributor
|
Client memory tests, node 24, client: |
FGoessler
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is specified as a peer dependency and should not be bundled (otherwise users end up with two copies of this package in their application).