Merged
Conversation
|
great i'm waiting for this pr |
jacek-prisma
approved these changes
Nov 24, 2025
jkomyno
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fixes #28624 This PR updates the dependency to the latest `better-sqlite3` version to allow installation on Node.js v24 without `node-gyp`. Upgrading `better-sqlite3` to v12.4.5 resolves this issue, as the [v12 branch](https://github.com/WiseLibs/better-sqlite3/releases/tag/v12.0.0) includes support for Node.js v24. While v12 drops support for Node v18, Prisma itself supports Node v20+ from its recent releases, so this should not introduce compatibility issues.
jkomyno
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fixes #28624 This PR updates the dependency to the latest `better-sqlite3` version to allow installation on Node.js v24 without `node-gyp`. Upgrading `better-sqlite3` to v12.4.5 resolves this issue, as the [v12 branch](https://github.com/WiseLibs/better-sqlite3/releases/tag/v12.0.0) includes support for Node.js v24. While v12 drops support for Node v18, Prisma itself supports Node v20+ from its recent releases, so this should not introduce compatibility issues.
jkomyno
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fixes #28624 This PR updates the dependency to the latest `better-sqlite3` version to allow installation on Node.js v24 without `node-gyp`. Upgrading `better-sqlite3` to v12.4.5 resolves this issue, as the [v12 branch](https://github.com/WiseLibs/better-sqlite3/releases/tag/v12.0.0) includes support for Node.js v24. While v12 drops support for Node v18, Prisma itself supports Node v20+ from its recent releases, so this should not introduce compatibility issues.
jkomyno
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fixes #28624 This PR updates the dependency to the latest `better-sqlite3` version to allow installation on Node.js v24 without `node-gyp`. Upgrading `better-sqlite3` to v12.4.5 resolves this issue, as the [v12 branch](https://github.com/WiseLibs/better-sqlite3/releases/tag/v12.0.0) includes support for Node.js v24. While v12 drops support for Node v18, Prisma itself supports Node v20+ from its recent releases, so this should not introduce compatibility issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28624
This PR updates the dependency to the latest
better-sqlite3version to allow installation on Node.js v24 withoutnode-gyp.Upgrading
better-sqlite3to v12.4.5 resolves this issue, as the v12 branch includes support for Node.js v24. While v12 drops support for Node v18, Prisma itself supports Node v20+ from its recent releases, so this should not introduce compatibility issues.