Skip to content

feat(generators): add biome ignore comment to all generated JS/TS files#28341

Merged
aqrln merged 2 commits intoprisma:mainfrom
lonelyevil:feat/generator/biome-comment
Oct 23, 2025
Merged

feat(generators): add biome ignore comment to all generated JS/TS files#28341
aqrln merged 2 commits intoprisma:mainfrom
lonelyevil:feat/generator/biome-comment

Conversation

@lonelyevil
Copy link
Copy Markdown
Contributor

Close #28340.

Please review and provide suggestions. Thanks!

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 21, 2025

CLA assistant check
All committers have signed the CLA.

@lonelyevil lonelyevil force-pushed the feat/generator/biome-comment branch from 4e3ecc5 to 490e823 Compare October 21, 2025 13:04
aqrln
aqrln previously approved these changes Oct 21, 2025
Copy link
Copy Markdown
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2025
@aqrln aqrln added this to the 6.18.0 milestone Oct 21, 2025
Copy link
Copy Markdown
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are currently failing, can you please fix them? Thanks

@lonelyevil
Copy link
Copy Markdown
Contributor Author

Tests are currently failing, can you please fix them? Thanks

Regenerated snapshots in the new commit, plz review.

Copy link
Copy Markdown
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the CI passes this time.

@aqrln aqrln added automerge and removed automerge labels Oct 22, 2025
@aqrln aqrln modified the milestones: 6.18.0, 6.19.0 Oct 22, 2025
@aqrln
Copy link
Copy Markdown
Member

aqrln commented Oct 22, 2025

I think this likely won't make it to 6.18.0 because we need to start the release soon, I changed the milestone to 6.19.0

@aqrln
Copy link
Copy Markdown
Member

aqrln commented Oct 23, 2025

@jkomyno could you please approve the PR or dismiss your previous blocking review, I'd like to merge this

@aqrln aqrln merged commit 11127b0 into prisma:main Oct 23, 2025
410 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(generators): add comment to let biome ignore generated ts/js files

4 participants