Skip to content

Add clean-changelog step to release script#15890

Merged
sosukesuzuki merged 3 commits intoprettier:mainfrom
sosukesuzuki:add-clean-changelog-unreleased-step
Jan 8, 2024
Merged

Add clean-changelog step to release script#15890
sosukesuzuki merged 3 commits intoprettier:mainfrom
sosukesuzuki:add-clean-changelog-unreleased-step

Conversation

@sosukesuzuki
Copy link
Copy Markdown
Contributor

Description

Context: #15889

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Copy Markdown
Member

fisker commented Jan 7, 2024

Let change the term "clean changelog unreleased" to "clean changelog", won't confuse anyway.

{
name: "Cleaning changelog_unreleased",
process: steps.cleanChangelogUnreleased,
skip: params.dry,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should skip for beta release too.

@sosukesuzuki sosukesuzuki changed the title Add clean-changelog-unreleased step to release script Add clean-changelog step to release script Jan 8, 2024
@sosukesuzuki
Copy link
Copy Markdown
Contributor Author

@fisker Thank you for your reviewing! I've addressed your comments.

@sosukesuzuki sosukesuzuki merged commit 6432f9b into prettier:main Jan 8, 2024
@sosukesuzuki sosukesuzuki deleted the add-clean-changelog-unreleased-step branch January 8, 2024 06:20
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 17, 2024
* Add clean-changelog-unreleased to release script

* Skip for beta release

* Rename to clean changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants