README.md: .go migrations package should be imported#968
Merged
mfridman merged 1 commit intopressly:mainfrom Jul 30, 2025
Merged
README.md: .go migrations package should be imported#968mfridman merged 1 commit intopressly:mainfrom
mfridman merged 1 commit intopressly:mainfrom
Conversation
.go migrations are not included into embedded dir along with .sql migrations. `import _` the `migrations` package for `init()` functions to be called.
mfridman
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.go migrations are not included into embedded dir along with .sql migrations,
for .go migrations Goose instead relies on SQL driver-style registration via
import _andinit().This is easy to miss.