Skip to content

Add starrocks dialect#810

Merged
mfridman merged 3 commits intopressly:masterfrom
barloc:starrocks
Sep 18, 2024
Merged

Add starrocks dialect#810
mfridman merged 3 commits intopressly:masterfrom
barloc:starrocks

Conversation

@barloc
Copy link
Copy Markdown
Contributor

@barloc barloc commented Aug 20, 2024

This PR introduces a new Starrocks dialect (https://www.starrocks.io/).
It uses mysql-go driver, but with new DDL for migrations table.

@ashwin-weave
Copy link
Copy Markdown

@mfridman Can we prioritise this? We have similar use case.

@saiteja2021
Copy link
Copy Markdown

Thanks for adding StarRocks support..!!
we are also waiting for this PR to be merged.

@barloc
Copy link
Copy Markdown
Contributor Author

barloc commented Sep 9, 2024

Hi. On new version 3.3.2 is issue with default current_timestamp StarRocks/starrocks#50872 :(

@mfridman
Copy link
Copy Markdown
Collaborator

Hi. On new version 3.3.2 is issue with default current_timestamp StarRocks/starrocks#50872 :(

I presume this just means we have to pin to a specific version, and then upgrade whenever it's resolved. A bit surprised because I don't think we're using any fancy database features, goose is intentionally kept simple to support as many databases.

Either way, happy to merge this as I see there's a few requests. Thanks for the contribution.

@mfridman
Copy link
Copy Markdown
Collaborator

A few merge conflicts, but otherwise this should be good to go. Please merge master and run go mod tidy.

@mfridman mfridman merged commit cf53a22 into pressly:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants