chore: Update 'replaceNode' deprecation comment to point at new shim#4844
Merged
rschristian merged 1 commit intov10.xfrom Jul 17, 2025
Merged
chore: Update 'replaceNode' deprecation comment to point at new shim#4844rschristian merged 1 commit intov10.xfrom
rschristian merged 1 commit intov10.xfrom
Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
Member
Author
|
Hrm, not related but it seems the PR reporter is now comparing the branch against Edit: Oh, it might be that the PR reporter action is out of date? Still weird though as the PR |
JoviDeCroock
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to the new shim package rather than the gist.
A comment on the gist stated they were seeing the comment on the deprecated overload even when not using the third parameter, and whilst I can't reproduce (it only pops up when I actually use the third param in my editor), I figured expanding the comment to explicitly mentioning
replaceNodewould be a good idea.