Update CommandEventHandler type to use EventHandler#4740
Merged
rschristian merged 1 commit intopreactjs:mainfrom Mar 31, 2025
Merged
Update CommandEventHandler type to use EventHandler#4740rschristian merged 1 commit intopreactjs:mainfrom
CommandEventHandler type to use EventHandler#4740rschristian merged 1 commit intopreactjs:mainfrom
Conversation
Update the `CommandEventHandler` type declaration to match other `*EventHandler` types by using the `EventHandler` utility. This fixes a downstream typing error reported in hypothesis/frontend-shared#1899 (comment).
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
rschristian
approved these changes
Mar 31, 2025
Member
rschristian
left a comment
There was a problem hiding this comment.
Good spot, I suppose #4692 mis-copied the existing types.
Looks like that PR (and a couple others perhaps) skipped the formatter on commit, maybe done by the web interface. Would have to get that correct at some point or another, may as well be now.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
CommandEventHandlertype declaration to match other*EventHandlertypes by using theEventHandlerutility. This fixes a downstream typing error reported inhypothesis/frontend-shared#1899 (comment).
Some unrelated formatting changes were applied when the commit was made. Is this expected?