refactor: Add default event target types for HTML attribute interfaces#4606
Merged
rschristian merged 4 commits intomainfrom Dec 15, 2024
Merged
refactor: Add default event target types for HTML attribute interfaces#4606rschristian merged 4 commits intomainfrom
rschristian merged 4 commits intomainfrom
Conversation
JoviDeCroock
approved these changes
Dec 13, 2024
Member
JoviDeCroock
left a comment
There was a problem hiding this comment.
This looks like a no-brainer honestly, great DX win, just the tests and we are good
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither React nor Solid (if I've understood their types right, had to go looking for that and it's seemingly not in their org? weird) do this so I'm a tad apprehensive as otherwise seems like a pretty obvious DX improvement. Take the following example:
Users can still supply the generic parameter if they wish but 99% of the time they're going to want the element associated with the attributes which we can simply assume as the default.