Clarify documentation for node.source.end.offset#2032
Merged
ai merged 3 commits intopostcss:mainfrom Apr 12, 2025
Merged
Conversation
ai
reviewed
Mar 22, 2025
lib/node.d.ts
Outdated
| * The inclusive ending position for the source | ||
| * code of a node. | ||
| * | ||
| * However, only `end.offset` may be an exclusive position. |
Member
There was a problem hiding this comment.
The wording is not very clear for everyone. I think it is better replace exclusive and inclusive words and show just an example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #2030
The behavior of
node.source.end.offsetis confusing to users. I want to reduce this confusion. So I have tried to describe the behavior in the documentation.