Skip to content

fix(reviewing): fix memory error in pnpm why#7122

Merged
zkochan merged 8 commits intomainfrom
fix-memory-error-why
Sep 27, 2023
Merged

fix(reviewing): fix memory error in pnpm why#7122
zkochan merged 8 commits intomainfrom
fix-memory-error-why

Conversation

@nachoaldamav
Copy link
Contributor

No description provided.

@nachoaldamav nachoaldamav marked this pull request as ready for review September 26, 2023 17:23
@zkochan zkochan merged commit 40798fb into main Sep 27, 2023
@zkochan zkochan deleted the fix-memory-error-why branch September 27, 2023 12:35
@gluxon
Copy link
Member

gluxon commented Sep 20, 2024

@zkochan @nachoaldamav Can we revert this PR? I don't think the pruneTree logic is correct. It's causing several correctness issues. In general, I think correctness is more important than memory usage.

@zkochan
Copy link
Member

zkochan commented Feb 9, 2026

Revert: #10582

but we need to fix the OOM errors somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants