Skip to content

chore: migrate ESLint Configuration to the new flat config format #8482

Merged
zkochan merged 7 commits intopnpm:mainfrom
pnodet:pnodet-1
Sep 1, 2024
Merged

chore: migrate ESLint Configuration to the new flat config format #8482
zkochan merged 7 commits intopnpm:mainfrom
pnodet:pnodet-1

Conversation

@pnodet
Copy link
Copy Markdown
Contributor

@pnodet pnodet commented Aug 29, 2024

After the migration I'm getting the exact same output from pnpm run lint:ts than the main branch.

Warning: eslint needs Node.js with version ^18.18.0, ^20.9.0, or >=21.1.0. Main branch version is currently 18.12.0

main branch:

Screenshot 2024-08-29 at 23 44 03

this pr:

Screenshot 2024-08-29 at 23 44 12

@pnodet pnodet requested a review from zkochan as a code owner August 29, 2024 21:48
@welcome
Copy link
Copy Markdown

welcome Bot commented Aug 29, 2024

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@pnodet
Copy link
Copy Markdown
Contributor Author

pnodet commented Aug 30, 2024

@zkochan Hi! I'm not familiar with the pnpm CI, not sure why the audit check is not passing, anything I can do to help fix?

@zkochan
Copy link
Copy Markdown
Member

zkochan commented Aug 31, 2024

There are some issues with the npm registry. That's why audit failed.

@pnodet
Copy link
Copy Markdown
Contributor Author

pnodet commented Aug 31, 2024

@zkochan Alright, any changes you'd want on this PR? For example upgrading the eslint deps (eslint v9, etc.) but feel like it would be better in a separate PR.

Comment thread eslint.config.mjs Outdated
Comment thread __utils__/eslint-config/index.js
@pnodet
Copy link
Copy Markdown
Contributor Author

pnodet commented Sep 1, 2024

@zkochan Maybe the eslint config needs a deeper update, to ensure it also lints *.js files.

Also the shared config used by the pnpm repo (eslint-config-standard-with-typescript) is not available anymore on npm, the package has been moved to https://github.com/mightyiam/eslint-config-love

@pnodet
Copy link
Copy Markdown
Contributor Author

pnodet commented Sep 1, 2024

@zkochan I can make additional changes to move to https://github.com/neostandard/neostandard which seems to be the spirit of the current configuration, would that be ok with you?

@pnodet
Copy link
Copy Markdown
Contributor Author

pnodet commented Sep 1, 2024

NB: this would be more changes since neostandard is specifying eslint v9, which is not currently supported by eslint-plugin-import

@zkochan zkochan merged commit 86732af into pnpm:main Sep 1, 2024
@welcome
Copy link
Copy Markdown

welcome Bot commented Sep 1, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@pnodet pnodet deleted the pnodet-1 branch September 1, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants