Skip to content

test: fix failures when retry downloading node#8477

Merged
zkochan merged 1 commit intomainfrom
fix-a-test
Aug 29, 2024
Merged

test: fix failures when retry downloading node#8477
zkochan merged 1 commit intomainfrom
fix-a-test

Conversation

@KSXGitHub
Copy link
Copy Markdown
Contributor

This should fix the failures like this:

subject test failure

@KSXGitHub KSXGitHub requested a review from zkochan as a code owner August 29, 2024 12:08
@zkochan
Copy link
Copy Markdown
Member

zkochan commented Aug 29, 2024

Why does it print undefined? Is there another way to fix it? Maybe at the place where undefined gets written?

@KSXGitHub
Copy link
Copy Markdown
Contributor Author

@zkochan I'm confused. What undefined are you referring to?

@KSXGitHub
Copy link
Copy Markdown
Contributor Author

KSXGitHub commented Aug 29, 2024

Oh, you meant node-version-undefined! That's the name I intentionally set (name: 'node-version-undefined') in package.json. It means that "this package.json doesn't define a node version, as opposed to others which do".

KSXGitHub added a commit that referenced this pull request Aug 29, 2024
zkochan pushed a commit that referenced this pull request Aug 29, 2024
* refactor: replace `undefined` to prevent confusion

Concerning #8477 (comment)

* test: fix
@zkochan zkochan merged commit 624e8b9 into main Aug 29, 2024
@zkochan zkochan deleted the fix-a-test branch August 29, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants