fix: shorten CAFS temp directory names (#12327)

scarab-systems · web-flow · commit 30c7590a264a · 2026-06-16T22:31:03.000+02:00
## Summary - use `fs.mkdtemp()` with a short `_tmp_` prefix for CAFS temporary package directories - remove `path-temp` from `@pnpm/store.create-cafs-store` - add git-fetcher regression coverage for short CAFS temp directories during git package preparation - add a patch changeset for `@pnpm/store.create-cafs-store` and `pnpm` ## Why This leaves more Unix socket path budget for lifecycle tools that create IPC sockets under `TMPDIR` during git-hosted dependency preparation. Closes #12222. ## Pacquet No pacquet change is included because the Rust git fetcher already uses `tempfile::tempdir()` instead of the TypeScript CAFS `path-temp` suffix changed here.
diff --git a/.changeset/short-pipes-dance.md b/.changeset/short-pipes-dance.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/store.create-cafs-store": patch
+"pnpm": patch
+---
+
+Create shorter CAFS temporary package directories to leave room for lifecycle scripts that create IPC socket paths under TMPDIR.
diff --git a/fetching/git-fetcher/test/index.ts b/fetching/git-fetcher/test/index.ts
@@ -47,6 +47,15 @@ beforeEach(() => {
   jest.mocked(globalWarn).mockClear()
 })
 
+test('uses short CAFS temp directories for git package preparation', async () => {
+  const storeDir = temporaryDirectory()
+  const tmpDir = await createCafsStore(storeDir).tempDir()
+
+  expect(path.dirname(tmpDir)).toBe(path.join(storeDir, 'tmp'))
+  expect(path.basename(tmpDir)).toMatch(/^_tmp_[a-zA-Z0-9]{6}$/)
+  expect(path.basename(tmpDir).length).toBeLessThanOrEqual(11)
+})
+
 test('fetch', async () => {
   const storeDir = temporaryDirectory()
   const fetch = createGitFetcher({ storeIndex: createStoreIndex(storeDir) }).git
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/store/create-cafs-store/package.json b/store/create-cafs-store/package.json
@@ -48,7 +48,6 @@
     "@pnpm/store.cafs": "workspace:*",
     "@pnpm/store.controller-types": "workspace:*",
     "memoize": "catalog:",
-    "path-temp": "catalog:",
     "ramda": "catalog:"
   },
   "peerDependencies": {
diff --git a/store/create-cafs-store/src/index.ts b/store/create-cafs-store/src/index.ts
@@ -14,7 +14,6 @@ import type {
   ImportPackageFunctionAsync,
 } from '@pnpm/store.controller-types'
 import memoize from 'memoize'
-import { pathTemp } from 'path-temp'
 
 export { type CafsLocker }
 
@@ -140,9 +139,8 @@ export function createCafsStore (
     storeDir,
     importPackage,
     tempDir: async () => {
-      const tmpDir = pathTemp(baseTempDir)
-      await fs.mkdir(tmpDir, { recursive: true })
-      return tmpDir
+      await fs.mkdir(baseTempDir, { recursive: true })
+      return fs.mkdtemp(path.join(baseTempDir, '_tmp_'))
     },
   }
 }
