Skip to content

fix: declare @types/react as peerDep to avoid phantom dep#1963

Merged
dai-shi merged 1 commit intopmndrs:mainfrom
leviosa-e:hotfix/declare_react_typings
Aug 1, 2023
Merged

fix: declare @types/react as peerDep to avoid phantom dep#1963
dai-shi merged 1 commit intopmndrs:mainfrom
leviosa-e:hotfix/declare_react_typings

Conversation

@leviosa-e
Copy link
Copy Markdown
Contributor

Related Issues or Discussions

Fixes #2047 of jotai

Summary

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 11:41am

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a79b4e2:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Collaborator

@sewera sewera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea :)

@dai-shi dai-shi added this to the v4.4.0 milestone Aug 1, 2023
@dai-shi dai-shi merged commit a2ad770 into pmndrs:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Declare @types/react as peerDeps to avoid phantom dep

3 participants