docs(auto-generating-selectors): Add vanilla store variant#1915
Merged
dai-shi merged 5 commits intopmndrs:mainfrom Jul 4, 2023
Merged
docs(auto-generating-selectors): Add vanilla store variant#1915dai-shi merged 5 commits intopmndrs:mainfrom
dai-shi merged 5 commits intopmndrs:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9672e1a:
|
sewera
suggested changes
Jul 3, 2023
Co-authored-by: Blazej Sewera <code@sewera.dev>
sewera
suggested changes
Jul 4, 2023
Collaborator
sewera
left a comment
There was a problem hiding this comment.
You didn't run yarn prettier.
Please don't check the checkbox in the PR that you've run it if you haven't. Please run yarn prettier the next time.
If you are unsure, please run it every time before you commit. It will save the time of the reviewers and yours as well. After all, it's our free time, so let's delegate the boring stuff to the machines.
Contributor
Author
|
@sewera You are right, I'm sorry. I think I ran the command on the Now I think it's ok. |
sewera
approved these changes
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The proposed change came from this discussion . The idea is to centralize both possibilities in the same wiki page.
Check List
yarn run prettierfor formatting code and docs