[cli] Make CLI default to multithreaded #5741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow specifying a number of threads relative to the number of cores of the machine. Default is 1C, ie one thread per core
|
Compared to main: (comment created at 2025-05-30 16:01:23+00:00 for 1924d23) |
oowekyala
commented
May 30, 2025
Member
Author
oowekyala
left a comment
There was a problem hiding this comment.
Thanks a lot for adding tests!
pmd-core/src/main/java/net/sourceforge/pmd/lang/impl/MonoThreadProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/net/sourceforge/pmd/cli/commands/typesupport/internal/NumThreadsConverter.java
Outdated
Show resolved
Hide resolved
...src/main/java/net/sourceforge/pmd/cli/commands/typesupport/internal/NumThreadsConverter.java
Outdated
Show resolved
Hide resolved
adangel
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Allow specifying a number of threads relative to the number of cores of the machine. Default is 1C, ie one thread per core
I'm still not sure how (or whether) to add a test for this...
This is enabled by #5593
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)