Skip to content

[java] Fix #4763 - wrong message for SimplifyBooleanReturns#5373

Merged
adangel merged 1 commit intopmd:mainfrom
oowekyala:issue4763-simplifyBooleanReturns-message
Nov 29, 2024
Merged

[java] Fix #4763 - wrong message for SimplifyBooleanReturns#5373
adangel merged 1 commit intopmd:mainfrom
oowekyala:issue4763-simplifyBooleanReturns-message

Conversation

@oowekyala
Copy link
Copy Markdown
Member

Curiously existing tests had correct comments but wrong test assertions...

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

Curiously existing tests had correct comments
but wrong test assertions...
@ghost
Copy link
Copy Markdown

ghost commented Nov 28, 2024

1 Message
📖 Compared to main:
This changeset changes 125 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel added this to the 7.8.0 milestone Nov 29, 2024
Copy link
Copy Markdown
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit bd280ba into pmd:main Nov 29, 2024
adangel added a commit that referenced this pull request Nov 29, 2024
adangel added a commit that referenced this pull request Nov 29, 2024
Merge pull request #5373 from oowekyala:issue4763-simplifyBooleanReturns-message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] SimplifyBooleanReturns - wrong suggested solution

2 participants