I started looking at this, and abandoned it after a while. I went off to see what it would take to get a real lexer for C# put in place. Still researching that.

While I do that, I think we can put this in as a stopgap. However, there are no tests for the CsTokenizer. I cannot commit this until there are.

I think, we should commit this, as we already added half of the initial patch: 85cc2b5

Therefore I created a unit test for the tokenizer. See: https://github.com/adangel/pmd/compare/cstokenizer

I agree, that the CsTokenizer might not be the long term way to integrate C#. But until we find a real lexer/grammar for C#, I'm in favor of merging this pull request for 5.0.1.

Me too.

I mean it's not the greatest feature ever, but it was kindly contributed,
it's probably working, at least to some extent, and it's not going to break
PMD. Morover, the rather limited implementation might trigger the will into
some other person to do a "full blown" parser...

On 22 November 2012 21:15, Andreas Dangel notifications@github.com wrote:

I think, we should commit this, as we already added half of the initial
patch: 85cc2b585cc2b5

Therefore I created a unit test for the tokenizer. See:
https://github.com/adangel/pmd/compare/cstokenizer

I agree, that the CsTokenizer might not be the long term way to integrate
C#. But until we find a real lexer/grammar for C#, I'm in favor of merging
this pull request for 5.0.1.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-10644050.

Romain PELISSE,
"The trouble with having an open mind, of course, is that people will
insist on coming along and trying to put things in it" -- Terry Pratchett
Belaran ins Prussia (blog) http://blog.wordpress.belaran.eu/ (...
finally up and running !)