Fix filter-sphere CLI number parsing#237
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CLI argument parsing for --filter-sphere so that Array.map no longer passes the element index into parseNumber’s optional min parameter, and adds regression tests intended to cover coordinates below their array indices and negative sphere centers.
Changes:
- Fix
--filter-sphereparsing by wrappingparseNumberin a single-argument lambda. - Add CLI regression tests for
--filter-spherewith small/negative coordinates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cli/index.ts | Fixes --filter-sphere numeric parsing to avoid accidentally using the array index as a minimum bound. |
| test/cli.test.mjs | Adds regression tests that spawn the CLI and validate --filter-sphere accepts small and negative coordinates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236.
Summary
--filter-sphereCLI parsing soArray.mapdoes not pass the element index asparseNumber's optional minimum.Testing
node --import tsx --test test\cli.test.mjsnpm.cmd run lintnpm.cmd test