fix: allow TreeView ArrowUp/ArrowDown navigation when item is focused but not selected#510
Merged
Merged
Conversation
… but not selected Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a keyboard navigation bug in the TreeView component where ArrowUp/ArrowDown keys failed to work when a TreeViewItem had focus but was not selected. The fix removes unnecessary selection state checks that were preventing navigation, making ArrowUp/ArrowDown behavior consistent with ArrowLeft/ArrowRight.
Changes:
- Removed
if (this._selectedItems.length)guard from ArrowUp/ArrowDown handlers - Navigation now works based on focused item regardless of selection state
- ArrowUp/ArrowDown behavior now matches ArrowLeft/ArrowRight pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TreeView._onChildKeyDownwere guarded byif (this._selectedItems.length)but ArrowLeft/ArrowRight were not_selectedItems(e.g. when an external consumer deselects the item while keeping it focused)itemparameter is always the focused TreeViewItem that generated the keydown event, making it a valid navigation starting point regardless of selection stateTest plan
Made with Cursor