feat: add expandAll() and collapseAll() methods to TreeView#504
Merged
Conversation
Made-with: Cursor
Made-with: Cursor
499e7c7 to
adc2cb8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small public API to TreeView for bulk expanding/collapsing items, primarily to avoid consumers (e.g. PlayCanvas Editor) reaching into protected internals for this common behavior.
Changes:
- Add
TreeView.expandAll()andTreeView.collapseAll()methods implemented via existing depth-first traversal. - Add unit tests covering the new methods.
- Update the TreeView HTML example to include “Expand All” / “Collapse All” buttons demonstrating the API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/TreeView/index.ts |
Introduces the new public methods using the existing _traverseDepthFirst helper. |
test/components/treeview.mjs |
Adds unit tests validating expand/collapse behavior across a small hierarchy. |
examples/elements/treeview.html |
Updates the example UI to provide buttons that call the new API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The PlayCanvas Editor currently works around the lack of these methods by directly accessing protected internals (_treeItemIndex, _rootItem) to implement expand/collapse all functionality. This PR provides a proper public API.
Test plan
pm test)