fix(examples): show resolved gsplat renderer in dropdown at startup#8953
Merged
Conversation
Register the renderer:set handler before the initial data.set('renderer',
AUTO) so the initial AUTO selection is resolved to the concrete renderer
and shown in the dropdown, matching the other gsplat examples.
Build size reportThis PR does not change the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three gaussian-splatting examples left the Renderer dropdown stuck on "Auto" at startup instead of showing the concrete renderer in effect.
The dropdown reflects
data.get('renderer'), and therenderer:sethandler is what resolves AUTO to the active renderer (currentRenderer) and writes it back. In these examples the handler was registered after the initialdata.set('renderer', AUTO), so the initial value was never resolved. Moved the handler registration above the initial set, matching the other gsplat examples (e.g. world).Changes:
renderer:setbefore initialdata.set