Remove fragile WebGL mipmap-based radix sort#8949
Merged
Merged
Conversation
Removes the experimental mipmap-prefix-sum GPU radix sort (FramePassRadixSort), its render passes, the associated GLSL/WGSL shader chunks, and the hidden test example. The approach relied on a hardware-mipmap prefix-sum trick that is fragile and fails on many devices, and was never wired into the gsplat rendering path. The WebGPU compute radix sort and the WebGL CPU worker sort are unaffected.
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the experimental mipmap-prefix-sum GPU radix sort (
FramePassRadixSort) and its example. This approach relied on a hardware-mipmap prefix-sum trick that is fragile and fails on many devices. It was never wired into the gsplat rendering path — gsplat continues to use the CPU worker sort on WebGL and the well-tested WebGPU compute radix sort (direct + indirect) on WebGPU, both of which are unaffected.Changes:
FramePassRadixSortand its render passes (RenderPassRadixSortCount,RenderPassRadixSortReorder)radix-sort-count/radix-sort-count-quad/radix-sort-reordershader chunksFramePassRadixSortexport from the public indexKept:
ComputeRadixSort: multipass + onesweep) and its compute shader chunksPrefixSumKernel(shared by the compute sort and gsplat interval compaction)radix-sort-computeandradix-sort-indirect-computeexamplesExamples:
test/radix-sortexample (the only consumer of the removed render pass)Note:
FramePassRadixSortwas@ignore, so this is not a public-API breaking change.