chore(gsplat): remove compute-renderer leftovers#8940
Merged
Conversation
Cleans up dead code left behind by the compute-renderer removal (#8921). - Remove the unused _createTonemapIncludes helper and its two orphaned shader-chunk imports from GSplatRenderer. - Refresh two stale comments that still referenced the compute renderer (class header + setDataSource JSDoc). - Remove the Occluder toggle from the lod-streaming example (control, orange cube, observer wiring); it only enabled sceneDepthMap for the compute rasterizer's manual depth test, which the raster path ignores.
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up two pieces of dead code left behind by the compute-renderer removal (#8921).
Changes:
_createTonemapIncludeshelper and its two now-orphaned shader-chunk imports fromGSplatRenderer(internal,@ignore).gsplat-renderer.jsthat still referenced the compute renderer (class header +setDataSourceJSDoc).lod-streamingexample (control, orange cube, and observer wiring). It only enabledsceneDepthMapfor the compute splat rasterizer's manual depth test; nothing in the raster path reads it, so it was dead demo UI.Examples:
gaussian-splatting/lod-streaming— "Occluder" toggle removed.