Remove highQualitySH option, always use high-quality per-splat SH#8938
Merged
Conversation
SOG gsplats now always evaluate spherical harmonics per-splat using the correct view direction (camera position to splat). The approximate "low quality" path is removed. The approximate path (GSplatResolveSH) evaluated a shared SH palette once per frame using the camera orientation (forward vector) rather than the per-splat view direction, so splat appearance changed incorrectly when rotating around the camera's nodal point. It was also effectively dead since the SOG-from-source refactor: its gsplatSogColorVS chunk override was no longer included by any shader, so highQualitySH = false silently dropped SH view-dependence instead of approximating it. - Remove GSplatComponent#highQualitySH (getter/setter) and the highQualitySH serialization property - Remove the highQualitySH constructor option and setHighQualitySH() method from GSplatInstance (both undocumented) - Delete gsplat-resolve-sh.js (GSplatResolveSH)
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOG gsplats now always evaluate spherical harmonics per-splat using the correct view direction (from camera position to each splat). The approximate "low quality" SH path and its
highQualitySHtoggle are removed.Why:
The approximate path (
GSplatResolveSH) resolved a shared SH palette once per frame from the camera orientation (forward vector) rather than each splat's view direction. As a result, splat appearance changed incorrectly when rotating around the camera's nodal point (and did not change under dolly). It was also effectively dead code since the "read SOG directly from source textures" refactor: itsgsplatSogColorVSchunk override is no longer#included by any shader, sohighQualitySH = falsesilently dropped SH view-dependence rather than approximating it. The remaining per-splat path already matched the component default (highQualitySH = true).Changes:
GSplatResolveSH(src/scene/gsplat/gsplat-resolve-sh.js) — the approximate SH-palette render pass and its dead chunk overrides.resolveSHfield/calls inGSplatInstance, and thehighQualitySHserialization property in the component system.API Changes:
GSplatComponent#highQualitySH(getter/setter).highQualitySHconstructor option and thesetHighQualitySH()method onGSplatInstance.gsplat.highQualitySH = falseno longer has any effect; SOG splats render with full per-splat SH.