refactor(input): remove dead and broken GamePads previous getter#8900
Merged
Merged
Conversation
The `previous` getter and its `_previous` backing field were unused (`@ignore`, no callers in engine, tests, or examples) and broken: it indexed buttons by gamepad index and recursed through `this.previous`, which would overflow the stack if ever called. Per-button `wasPressed`/`wasReleased` state on GamePadButton superseded it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused, broken
GamePads#previousgetter and its_previousbacking field.It was
@ignorewith no callers (engine, tests, or examples) and would overflow the stack if ever called — it indexed buttons by gamepad index and assigned throughthis.previous, re-entering the getter. Per-buttonwasPressed/wasReleasedstate onGamePadButtonhas long since superseded it.Spotted while reviewing #1014. No public API change (the getter was
@ignore, so it never appeared in generated types); lint andnpm run test:typespass.🤖 Generated with Claude Code