test(element): cover reparenting an element after its screen is destroyed#8899
Merged
willeastcott merged 1 commit intoJun 14, 2026
Merged
Conversation
…oyed Regression test for #1151: an element reparented to null, whose screen is then destroyed (e.g. on scene unload), can be reparented again without throwing 'this.screen.screen is undefined'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for #1151: an element reparented to
nullwhose screen is then destroyed (e.g. on scene unload) can be reparented again without throwingthis.screen.screen is undefined.The behaviour is already correct in current code — the screen's
onBeforeRemoveclears the danglingscreenreference on its bound elements — so this just locks it in. The existing tests covered reparenting to a non-screen parent and destroying the element, but not this combination.🤖 Generated with Claude Code