refactor(physics): split rigid-body data classes into separate modules#8897
Merged
Conversation
Move RaycastResult, SingleContactResult, ContactPoint and ContactResult out of system.js into their own one-class modules, matching the engine's one-class-per-file convention. Behavior-neutral; the public API is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits the four public physics data classes —
RaycastResult,SingleContactResult,ContactPoint, andContactResult— out ofrigid-body/system.jsinto their own one-class modules, leavingRigidBodyComponentSystemas the only class insystem.js.They are pure data containers with no dependency on the system (the system constructs/pools them, not the reverse), so the move is behavior-neutral and the public API is unchanged — all five classes remain exported from
src/index.js(pc.RaycastResult, etc.). This matches the engine's one-class-per-file convention (cf.collision/trigger.js) and trimssystem.jsfrom ~1110 to ~790 lines.Checklist
🤖 Generated with Claude Code