Skip to content

fix(examples): restore MiniStats panel after hot reload#8896

Merged
willeastcott merged 1 commit into
mainfrom
fix/examples-ministats-hot-reload
Jun 14, 2026
Merged

fix(examples): restore MiniStats panel after hot reload#8896
willeastcott merged 1 commit into
mainfrom
fix/examples-ministats-hot-reload

Conversation

@willeastcott

Copy link
Copy Markdown
Contributor

Description

Follow-up to #8894 for the remaining part of #8893: MiniStats was still broken on hot reload (the code-editor play button). Hitting it hid the panel, which only returned after toggling the MiniStats button twice.

A hot reload destroys the app and its MiniStats, but exampleLoad — which re-applies the UI's MiniStats toggle — only fires on first start. The loader now remembers the requested state and re-applies it when the example restarts.

Verified in the examples dev server with puppeteer: example loads with MiniStats visible → click play → MiniStats persists. Reverting the change reproduces the disappearance.

Fixes #8893

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

A hot reload destroys the app and its MiniStats, but 'exampleLoad' - which
re-applies the UI's MiniStats toggle - only fires on first start, so the panel
stayed hidden until the button was toggled twice. Remember the requested state
and re-apply it when the example restarts.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@willeastcott willeastcott self-assigned this Jun 14, 2026
@willeastcott willeastcott merged commit d19586e into main Jun 14, 2026
9 checks passed
@willeastcott willeastcott deleted the fix/examples-ministats-hot-reload branch June 14, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On the examples page, when you click the reload button, the scene light breaks.

1 participant