Add foveated contribution culling to the GPU-sort gsplat renderer#8869
Merged
Conversation
Raises the contribution-culling threshold radially from the screen centre, so low-impact splats are culled increasingly toward the edges where peripheral overdraw dominates XR frame cost. Effective threshold: minContribution + foveationStrength * smoothstep(foveationCenter, 1, length(ndc)) - GSplatParams: new foveationStrength (default 0 = off) and foveationCenter (default 0.3, protected-centre radius) — GPU-sort (hybrid) renderer only. - Projector: values plumbed via dispatch params and the projector UBO; the cull in computeSplatCov applies the radial boost (exact no-op at strength 0). - Compute-local renderer is unaffected (passes inert constants). - vr-lod example: in-XR HUD number row to tune strength (+/- 5, 0..50).
Public API reportThis PR changes the public API surface (+4 / −0), per the docs' rules (@ignore / @Private / undocumented are excluded). Show API diff+GSplatParams.get foveationCenter(): number
+GSplatParams.get foveationStrength(): number
+GSplatParams.set foveationCenter(value: number)
+GSplatParams.set foveationStrength(value: number)Informational only — this never fails the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional foveated mode to the GPU-sort (hybrid) gsplat renderer's contribution culling: the
minContributionthreshold is raised radially from the screen centre, so low-impact splats are culled increasingly toward the screen edges — where peripheral overdraw dominates XR frame cost — while the centre is untouched.The effective threshold is:
with
r = length(ndc)being 0 at the screen centre, 1 at the edge (corners beyond 1 get full strength).Changes:
GSplatParams.foveationStrength(default 0 = off) andGSplatParams.foveationCenter(default 0.3, the protected-centre radius in NDC units). Only used by theGSPLAT_RENDERER_RASTER_GPU_SORTrenderer.GSplatManager→ projector dispatch params → projector UBO → the sharedcomputeSplatCovcull, which applies the radial boost. With strength 0 the cull is bit-identical to before (additive 0); no shader variant is added — the cost is a few ALU once per splat in the projection compute pass.API Changes:
GSplatParams#foveationStrength— new property (number, default 0).GSplatParams#foveationCenter— new property (number, default 0.3).Examples:
gaussian-splatting-xr/vr-lod: new in-XR HUD number row to tune the strength live (+/- 5, clamped 0–50).Performance: