Skip to content

Remove alphabetical import-order requirement from examples lint#8862

Merged
mvaligursky merged 1 commit into
mainfrom
mv-examples-no-alpha-imports
Jun 8, 2026
Merged

Remove alphabetical import-order requirement from examples lint#8862
mvaligursky merged 1 commit into
mainfrom
mv-examples-no-alpha-imports

Conversation

@mvaligursky

Copy link
Copy Markdown
Contributor

Drops the alphabetical ordering requirement for imports in the examples package. Reordering imports purely to satisfy alphabetical order adds churn without real benefit, and the constraint isn't applied to the engine source (src/, scripts/) — only to examples — so it was an inconsistent surprise.

Changes:

  • Remove the alphabetize option from the import/order rule in examples/eslint.config.mjs. Group ordering (builtin → external → internal → parent/sibling …) and newlines-between: always are kept, so imports stay grouped and separated — they just no longer need to be alphabetical within a group.

No example sources needed changes (removing a constraint cannot introduce new violations); examples lint passes.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Public API report

✅ No public API changes in this PR.

@mvaligursky mvaligursky merged commit ac6d562 into main Jun 8, 2026
9 checks passed
@mvaligursky mvaligursky deleted the mv-examples-no-alpha-imports branch June 8, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant