Remove alphabetical import-order requirement from examples lint#8862
Merged
Conversation
Public API report✅ No public API changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the alphabetical ordering requirement for imports in the examples package. Reordering imports purely to satisfy alphabetical order adds churn without real benefit, and the constraint isn't applied to the engine source (
src/,scripts/) — only to examples — so it was an inconsistent surprise.Changes:
alphabetizeoption from theimport/orderrule inexamples/eslint.config.mjs. Group ordering (builtin → external → internal → parent/sibling …) andnewlines-between: alwaysare kept, so imports stay grouped and separated — they just no longer need to be alphabetical within a group.No example sources needed changes (removing a constraint cannot introduce new violations);
exampleslint passes.