fix: include error message context in load failure logs#8743
Merged
Conversation
External error reporters typically serialize console.error arguments via
JSON.stringify. Error objects have non-enumerable message/stack
properties, so a raw Error as the sole argument serializes to {},
producing reports with no actionable context.
Update ResourceLoader._onFailure, I18n.addData/removeData and
AssetRegistry material texture loader to also log a string-form summary
(including err.message and the relevant key/name) while still passing
the original Error for dev tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External error reporters (e.g. Poki) typically capture
console.errorarguments viaJSON.stringify.Errorobjects have non-enumerablemessage/stackproperties, so passing a rawErroras the only argument serializes to{}, producing dashboard entries likeconsole.error: [{}]with no actionable context.This patches the three engine call sites that logged raw errors to also include a string-form summary, while still passing the original
Erroras a secondary argument so it remains expandable in dev tools.Changes:
ResourceLoader._onFailure: log the resource key pluserr.messageI18n.addData/I18n.removeData: log the method name pluserr.messageAssetRegistry._loadTextures(material texture loader): log the material asset name pluserr.messageAPI Changes:
console.errorchanged.