fix(examples): avoid clipping select dropdowns in landscape controls#8715
Merged
Conversation
Scroll only the example controls region so the Active Device (and other non-controls UI) stays outside overflow-y, restoring uncropped dropdowns while keeping long parameter lists scrollable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8707: scrolling the whole
.pcui-panel-contentclipped PCUISelectInputmenus (they useposition: absoluteinside the overflow region). Examples with only Active Device (e.g. loaders/bundle) showed an empty-looking dropdown until the panel was scrolled.Changes:
renderControls()in#controlPanel-scroll-regionso only example parameters scroll.min-height: 0so the scroll area still fills remaining height when the panel hits its max height.#controlPanel.landscapetooverflow: visibleand cap height withmax-height: min(calc(100% - 16px), calc(100vh - 48px))so tall control lists remain usable on short viewports.Note:
SelectInputcontrols that live inside a long, scrolled.controls.mjspanel can still be clipped if their list opens past the bottom of#controlPanel-scroll-region; fixing that would require rendering the list outside the scroll subtree (e.g. PCUI portal/fixed overlay).