fix(examples): scroll landscape controls panel when content overflows#8707
Merged
Conversation
Match sidebar behavior so tall parameter lists work on short viewports and touch devices (e.g. Meta Quest browser).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landscape (desktop-width) examples UI placed parameters in
#controlPanelwithout a scroll region, so long controls files were unusable when the window was shorter than the panel—unlike the left sidebar, which already usedoverflow: autoon#sideBar-contents.Changes:
#controlPanel.landscape: clip the panel withoverflow: hiddenand make.pcui-panel-contentthe scroll container viaoverflow-y: auto, with a viewport-basedmax-heightandmin-height: 0for reliable overflow.This restores wheel/trackpad/scrollbar and touch scrolling on short viewports and devices such as Meta Quest Browser.