feat(gsplat): Remove raster GPU sort path and sort-key compute#8685
Merged
Conversation
- Drop GSPLAT_RENDERER_RASTER_GPU_SORT; set GSPLAT_RENDERER_RASTER_HYBRID to 2 - Remove quad+sort-key compute+radix path from gsplat-manager; delete dead modules - Update gaussian-splatting examples and benchmark renderer options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the experimental WebGPU path that combined
GSplatQuadRendererwith a separate sort-key compute pass and indirect radix sort, along withGSplatSortKeyComputeand its WGSL chunk. The hybrid raster pipeline (GSplatProjector+ radix sort) is unchanged.Changes
GSPLAT_RENDERER_RASTER_GPU_SORTand the manager code path that usedGSplatSortKeyCompute+sortGpu/dispatchGpuSort.GSPLAT_RENDERER_RASTER_HYBRIDto2(was4);GSPLAT_RENDERER_COMPUTEremains3.gsplat-sort-key-compute.jsand WGSL chunkcompute-gsplat-sort-key.js; adjust related comments incompute-gsplat-projector.jsandgsplat-sort-bin-weights.js.v: 2. Benchmark: one fewer column, usepc.GSPLAT_RENDERER_*forRENDERERS.Public API
GSPLAT_RENDERER_RASTER_GPU_SORTremoved (was2).GSPLAT_RENDERER_RASTER_HYBRIDvalue is now2(was4). Code that passed the hybrid mode as the number4should use2or the constant.