docs: Fix executeCallback JSDoc type in gsplat-resolve-sh#8682
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the JSDoc type annotation for CustomRenderPass.executeCallback in the gsplat SH resolve pass so that it is interpreted as a nullable callback (rather than a callback returning a nullable value), aligning the documentation with how the property is initialized (null) and later assigned (a function).
Changes:
- Fix
executeCallbackJSDoc from() => void | nullto(() => void) | nullto correctly represent a nullable function value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the JSDoc for
CustomRenderPass.executeCallback. The previous annotation() => void | nullwas parsed as a function returningvoid | null, not a nullable callback. The property is initialized asnulland later assigned a function, so the type is(() => void) | null.