Exclude skinned and morphed mesh instances from batching#8477
Merged
Conversation
slimbuck
approved these changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents skinned and morphed MeshInstances from being added to batch groups, addressing issue #8474 where animated entities could lose skinning/morph state after rebatching.
Changes:
- Added a batching eligibility check to exclude any model/render component whose mesh instances include
skinInstanceormorphInstance. - Emitted a one-time debug warning when a component mixes batchable and non-batchable mesh instances (and therefore is fully excluded).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvaligursky
added a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8474
Summary