[FIX] Fix XrInputSource crash when grip unavailable#8389
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash that occurred when getPosition() or getRotation() was called on an XrInputSource before grip data became available from WebXR. The issue was caused by incorrect null guards that checked always-initialized member variables instead of the grip availability flag.
Changes:
- Fixed null guards in
getPosition()andgetRotation()to check_gripinstead of_position/_rotation - Added defensive null checks in
XrControllersscript before callingsetPosition()andsetRotation()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/framework/xr/xr-input-source.js | Fixed null guards to properly check grip availability before accessing transforms |
| scripts/esm/xr-controllers.mjs | Added defensive null checks when applying position and rotation to controller entities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Good catch! 🙏 |
slimbuck
approved these changes
Jan 20, 2026
Maksims
approved these changes
Jan 20, 2026
willeastcott
added a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of null (reading 'setTRS')crash in VR modegetPosition()andgetRotation()now correctly returnnullwhen grip data is not yet available, as documentedXrControllersscriptTechnical Details
The
getPosition()andgetRotation()methods had incorrect null guards:The crash occurred when
getPosition()was called before the first validgripPosewas received from WebXR. The_localTransformmatrix is only created when_gripbecomes true, but the old guard checked_positionwhich is always a validVec3.This aligns the implementation with the existing JSDoc contract: "Get the world space position of input source if it is handheld (grip is true). Otherwise it will return null."
Checklist