Fix: potential OOM in TreeFromNodes for large limits#65
Merged
pk910 merged 3 commits intopk910:masterfrom Dec 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 83.65% 87.65% +3.99%
==========================================
Files 34 34
Lines 5856 5831 -25
==========================================
+ Hits 4899 5111 +212
+ Misses 572 424 -148
+ Partials 385 296 -89
🚀 New features to boost your workflow:
|
Owner
|
Thanks for the fix, this looks very good (again :D). |
|
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the TestBeaconState_BlockRootAtIndexProof test in fastssz, TreeFromNodes was invoked with a very large limit derived from a generalized index. Allocating memory based on this limit caused excessive allocations and resulted in an out-of-memory (OOM) error.
This change avoids allocating storage proportional to limit and instead constructs the tree bottom-up using only the actual number of leaves, filling missing nodes with zero-hashes. This keeps memory usage bounded and prevents OOM when limit is much larger than the real tree size.