Add NewPacketizerWithOptions for configuration#305
Merged
Conversation
Add NewPacketizerWithOptions to create and configure packetizers, mainly to make it possible to create packetizers with custom timestamp, And for extra options in the future.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 86.76% 86.88% +0.11%
==========================================
Files 26 26
Lines 3061 3087 +26
==========================================
+ Hits 2656 2682 +26
Misses 348 348
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@Sean-Der this has been in my mind for a while, I'm not sure if this is the right way to do it or wait for the new major release! |
Member
|
Go for it! Much nicer not having all the args :) |
Sean-Der
approved these changes
Apr 25, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add NewPacketizerWithOptions to create and configure packetizers, mainly to make it possible to create packetizers with custom timestamp, And for extra options in the future.
Also removed
ssrcandPayloadTypefrom the arguments, we don't use it.This probably should replace
NewPacketizerin the new major release.Reference issue
Fixes #111