Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 85.99% 86.69% +0.69%
==========================================
Files 26 26
Lines 2913 3043 +130
==========================================
+ Hits 2505 2638 +133
+ Misses 350 348 -2
+ Partials 58 57 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Feb 26, 2025
65028cb to
4534adf
Compare
Member
Author
|
@Sean-Der I can confirm that this is working with chrome and gstreamer |
Sean-Der
approved these changes
Feb 28, 2025
59a09ef to
0c5defe
Compare
Member
Author
|
Thanks, I'll test it a bit more with bigger files and real video data and merge it tonight :) |
Member
|
@joeturki you are a better tester/more detail oriented then me :) Thanks for doing this. This is going to help a lot of people building cool stuff. I am very excited for you to get the credit/attention for it! |
2146e1f to
342e9d9
Compare
1. Rewrite the AV1 Payloader according to the spec.
2. AV1 bitstream reader.
3. Tries to optimize the use of the W field as much as possible to
reduce the size of the packet.
4. Added tests around edge cases.
This was referenced Mar 2, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tested and works as intended. I'll update the examples in the WebRTC repo accordingly.
Reference issue
pion/webrtc#3036
pion/webrtc#2788
#273
pion/webrtc#2639