Skip to content

Move logic of missing whitespace before block comment to NoSingleLineBlockCommentRule#2979

Merged
paul-dingemans merged 1 commit intomasterfrom
2936
May 5, 2025
Merged

Move logic of missing whitespace before block comment to NoSingleLineBlockCommentRule#2979
paul-dingemans merged 1 commit intomasterfrom
2936

Conversation

@paul-dingemans
Copy link
Copy Markdown
Collaborator

Description

Move logic of missing whitespace before block comment to NoSingleLineBlockCommentRule

In #2000 the NoSingleLineBlockCommentRule was extracted from the CommentWrappingRule. Some logic was left behind in the old rule, causing an exception when running with other code style than ktlint_official. As a result, the dependency from NoSingleLineBlockCommentRule on CommentWrappingRule is also no longer needed.

Closes #2936

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

…BlockCommentRule

In #2000 the `NoSingleLineBlockCommentRule` was extracted from the `CommentWrappingRule`. Some logic was left behind in the old rule, causing an exception when running with other code style than `ktlint_official`. As a result, the dependency from `NoSingleLineBlockCommentRule` on `CommentWrappingRule` is also no longer needed.

Closes #2936
@paul-dingemans paul-dingemans added this to the 1.6 milestone May 5, 2025
@paul-dingemans paul-dingemans merged commit f3d4266 into master May 5, 2025
10 checks passed
@paul-dingemans paul-dingemans deleted the 2936 branch May 5, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intellij_idea coding style can not format block comments to line comments at the end of a statement

1 participant