!array_key_exists() should imply array for PHP8+#4417
Merged
ondrejmirtes merged 14 commits intophpstan:2.1.xfrom Oct 16, 2025
Merged
!array_key_exists() should imply array for PHP8+#4417ondrejmirtes merged 14 commits intophpstan:2.1.xfrom
!array_key_exists() should imply array for PHP8+#4417ondrejmirtes merged 14 commits intophpstan:2.1.xfrom
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Oct 7, 2025
| throw new \RuntimeException('Absolute URLs are prohibited for the redirectTo parameter.'); | ||
| } | ||
|
|
||
| assertType('array{scheme?: string, host?: string, port?: int<0, 65535>, user?: string, pass?: string, path?: string, query?: string, fragment?: string}', $parsedUrl); |
Contributor
Author
There was a problem hiding this comment.
in this case we got more preicse, because we no longer have a union array{...}|false but just the plain array-shape.
but on the other hand we no longer know that the 'host' offset cannot exist at this point.
I tried several variants, but wasn't successfull in combining the specified types in a way which turns the mixed into array while also removing the offset.
e479f0e to
cebec02
Compare
Contributor
Author
|
Memo for me: add test for the issue-bot report Edit: ✅ |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#6209
closes phpstan/phpstan#13301