Avoid crashing on enum without value#4336
Conversation
5467bcc to
1428e9b
Compare
ondrejmirtes
left a comment
There was a problem hiding this comment.
I don't want to catch LogicException. The right way to prevent this is to contribute something like hasValueExpression first to https://github.com/ondrejmirtes/BetterReflection to prevent the error.
Please note that contributing to that fork is a bit tricky. The last two commits are always "[GENERATED] Renamed" and "[GENERATED] Downgrading".
You need to start by git reset --hard before these two commits. Then make your changes. Then run make downgrade-inner (and commit that) and make rename-inner (and commit that).
Please note that the CI there isn't green. The library could appreciate some love but given it's only just me working on the fork I didn't prioritize that yet.
1428e9b to
f6157ba
Compare
|
I actually disagree with merging Roave/BetterReflection#1527 instead of Roave/BetterReflection#1528. Since I'll rebase the fork and adjust it to my taste. |
|
Updated here. |
a62d108 to
33a4ebb
Compare
Thanks, rebased and updated :) |
|
Thank you! |
Closes phpstan/phpstan#7927