Consider assert as side effect#4227
Merged
ondrejmirtes merged 3 commits intophpstan:2.1.xfrom Sep 12, 2025
Merged
Conversation
a3b0037 to
21bcb53
Compare
ondrejmirtes
requested changes
Sep 7, 2025
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
What about CallToConstructorStatementWithoutSideEffectsRule?
848ac1a to
214ca45
Compare
Contributor
Author
The issue only appear if you use both Anyway it doesn't really cost to add the check, so I updated the PR. |
214ca45 to
3ef76ab
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12224