Resolve static in assert phpdoc#4222
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Sep 12, 2025
Merged
Conversation
f3313df to
1c4959b
Compare
Member
|
Aren't both phpstan/phpstan#11289 and phpstan/phpstan#12376 fixed too? |
aa4e1ba to
944ade1
Compare
944ade1 to
dd527ab
Compare
Contributor
Author
Indeed, I added non regression tests |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12548
I didn't exactly copy-paste the snippet given because I don't understand how you can expect
to correctly work:
phpstan-assert-if-trueonly work if the method returns a boolean.Closes phpstan/phpstan#11289
Closes phpstan/phpstan#12376