Fix IntersectionType::isIterableOnce#4106
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Jul 21, 2025
Merged
Conversation
82a2630 to
0411ad9
Compare
ondrejmirtes
requested changes
Jul 21, 2025
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
This is great, thank you.
Member
|
Also, there might be more candidates to also use a filter in IntersectionType: hasOffsetValueType/getOffsetValueTypesetOffsetValueType (should use isOffsetAccessible) Feel free to explore that with a failing test in a separate PR. Thank you! |
Member
|
But maybe not because ObjectType::isOffsetAccessible() says "maybe" for non-final classes which is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13248
I feel like non-iterable should be excluded since as soon as one subtype is iterable the whole intersection is iterable.